- You can add set other fields, but don't change the Owner. That way the committee sees the incoming tickets (those marked as Owner: somebody).
- If you really have to fix a bug right away, file it and send a notice to cldr-dev explaining what you are doing and why. Otherwise, file the bug, wait for the next Wednesday meeting for discussion and approval.
- The latest ticket workflow should be listed at CldrWorkflow on the trac server, and is pictured below.
- The committee assesses the tickets weekly.
- Straightforward ones are just assigned and prioritized and given a milestone.
- Questionable ones are assigned, but left with priority=assess. The assignee will report back before doing anything.
- More complicated ones are moved into the
design folder for later discussion at the meeting.
- Don't fix a bug until it's been approved.
- If a ticket has multiple owners, the Notes must describe who is doing what. Otherwise it needs to be split into multiple tickets.
- Assignees periodically review and take care of their tickets.
- Go to http://unicode.org/cldr/trac/report/14 for My Tickets
- design: You must go back to the committee with the completed design before checking anything in. For example, if the ticket doesn't describe an exact DTD structure, then add the proposed structure to the ticket in a comment, and send an email to the committee asking whether anyone objects.
- assess: Tickets marked "assess" need to be evaluated for priority (or whether to do them at all). Send your suggested disposition to the cldr group by email.
- duplicate: If the ticket is a duplicate, any extra information is copied to the other ticket, an xref is set in both, and the ticket is returned.
- If the ticket requires separate phases, such as a change to the spec, then a separate ticket is filed, with xrefs set in both.
- If part of a ticket cannot be completed in the release:
- Set the milestone to the release number
- Add a comment indicating what part of the ticket was done, and what part wasn't.
- Set a reviewer.
- Create a new ticket for the remaining work, with an xref to the old bug.
- If the ticket can't be done due to lack of time, or is being downgraded in priority from major or above to below major, send an email to the cldr group.
- If during the course of doing the ticket, the person runs up
against a problem, then send a message to the cldr group. Examples:
- The description doesn't work
- Another mechanism looks better
- If you are making any DTD changes, please follow the instructions on Updating DTDs.
- Add unit tests for changes you make, then
- Make sure to run the tests in Running Tests!
Skipping test failures
If there is a test failure that is due to a bug that cannot be fixed right now (eg it requires a data change, but it is past the data freeze), then use the logKnownIssue() method to disable the test. See http://site.icu-project.org/setup/eclipse/time
for details, and look in the CLDR test code for some examples of usage.
Survey Tool in Production Phase!
- Before you make a commit, add a line to the Issues spreadsheet below (Spreadsheet View), with status OPEN, bug number, short desc.
When you're ready for checking, add the commit number to your line, send a message to a designee (cc cldr-dev) and change the status to CHECK, add testing description (what to check, links if possible).
Designee changes status to READY, or communicates problems back to you.
- Don't do this if there is a status=PUSHING
Once the statuses are all READY, anyone can push to production:
- All changes checked into SVN for the ticket use the format "cldrbug XXX: <description>", where XXX is the ticket number.
- Don't mark the bug as fixed! Instead,
- Once the ticket is done, assign a reviewer.
- Send a message to the reviewer if the review should be done soon.
If you accidentally check something in with the wrong ticket number...
- Add a comment to the ticket you checked in against describing the misticketed commits.
- Navigate to the wiki page http://unicode.org/cldr/trac/wiki/MisTicketed
- Click "Edit This Page" (logging in first if needed)
- Add your new line immediately after the first line in the page. (other example lines shown for context)
(In the example below, revision 6658 was checked in under ticket 6636, but should have been under 4453.)
||r6658||ticket:6636||ticket:4453||This is a comment||
||r6973||||ticket:4594||already fixed, just needs cache update||
- Click "Submit Changes"
- Send an email to the cldr-dev list with notification that you have changed the Misticketed page.
- On "Available Reports", click on My Reviews.
- For each of your tickets to review, open it and do the following:
- First read the description and comments/replies in the original ticket, since they may contain changes or additions, and also sometimes alert you to changes not captured by the diff tool.
- In the top right, under View Tickets, you'll see "Review <x> commits." Click on that to see the changed files. (Often best to to see side-by-side, with right-click > open in new window.)
- In the Changes column, click on each of the items (eg, edit) in each of the cells, and make sure that the
implementation matches the description.
- For data tickets, the goal is to verify that the data in the ticket matches what is entered in.
- For spec tickets, it is often easier to go to the Modifications section of the latest proposed spec update, search for the modifications entry with the ticket number for the change that you are reviewing, and then click in that entry’s link to the relevant portion of the spec. The modifications in that section will be shown in yellow, and that is what you need to review.
- Once you are done, go back to the original ticket (you can click on it at the top), and hit "Modify Ticket" near the bottom.
- If the implementation looks good:
If any problems are found
- click "REVIEWER: Close as fixed", then
- click "Submit changes"
Hit "Submit changes"If any issues come up or the topic needs general review, send a message to the email@example.com list.
- add a comment to original ticket describing the problems you found
- click "back to owner"
- click "Submit changes"
- if time is short (near the end of the release), send an email to the owner also.
- All reviewers should be done well before the end of the release, so that any problems can be taken care of.
- At release time, all the tickets with status "fixed" are changed to "closed".
Start of Release
- The future folder tickets are moved to the discuss folder
- Unscheduled tickets (with no release number) are re-evaluated.